Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce GMD + ATD #479

Merged
merged 14 commits into from
Jan 10, 2023
Merged

Introduce GMD + ATD #479

merged 14 commits into from
Jan 10, 2023

Conversation

thagikura
Copy link
Contributor

  • Introduce Gradle Managed Device definition in a single module (core-database at the moment) using Automated Test Device

@dturner
Copy link
Collaborator

dturner commented Dec 12, 2022

GMD setup is failing with:

Execution failed for task ':core:database:pixel4api30Setup'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.ManagedDeviceSetupTask$ManagedDeviceSetupRunnable
   > java.lang.IllegalStateException: Snapshot setup ran successfully, but the snapshot failed to be created. This is
     likely to a lack of disk space for the snapshot. Try the cleanManagedDevices
     task with the --unused-only flag to remove any unused devices for this project.

https://github.com/android/nowinandroid/actions/runs/3673045398/jobs/6212504226

@thagikura
Copy link
Contributor Author

I ran it 10 times and failed it due to the lack of disk space 2 times.
https://github.com/android/nowinandroid/actions/runs/3673045398

I'll see if it can be stabilized.

@thagikura thagikura mentioned this pull request Dec 13, 2022
Closed
@thagikura
Copy link
Contributor Author

After this commit 392408c as advised in https://issuetracker.google.com/issues/216744701,

2 attempts still failed out of 10 attempts.

Now I enabled more logging in this set of Actions.
https://github.com/android/nowinandroid/actions/runs/3683976750

If we still see failed jobs, I'm considering filing a bug against GMD.

@thagikura thagikura mentioned this pull request Dec 14, 2022
Closed
@thagikura
Copy link
Contributor Author

The last 10 attempts succeeded as in https://github.com/android/nowinandroid/actions/runs/3683976750

Do you think it's acceptable @dturner ?
In case if it fails in the future, I also enabled the detailed logging to pass it to the product team.

Also this PR only enables GMD in the core-database module, the rest of the modules need to be addressed, too.

@thagikura
Introduce GMD + ATD
5da6c76 
- Introduce Gradle Managed Device definition in a single module
  (core-database at the moment) using Automated Test Device
@thagikura
Append -Dorg.gradle.workers.max flag and ./gradlew cleanManagedDevices
e0100a3 
task

Change-Id: Ibec569886c3bc8f94f402a62c7dc4205b628eec6
@thagikura
Add more flags to the GMD running command
cb22405 
Change-Id: I491e4eb82a1b64842902023dd20993e89ee3ef0c
@dturner dturner self-requested a review December 21, 2022 17:28
dturner
dturner requested changes Dec 21, 2022
View reviewed changes
Copy link
Collaborator

@dturner dturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try using GMD everywhere so we can compare it with ReactiveCircus for the whole codebase.

@thagikura
Copy link
Contributor Author

Let's try using GMD everywhere so we can compare it with ReactiveCircus for the whole codebase.

Agreed. Let's see the flakiness to compare with ReactiveCircus.

@thagikura
Add test reports
30c662e 
Add GMD to other modules that have instrumented tests

Change-Id: I9355b3792bf9cec98a7a4dbe66ea9c1332a29a79
@thagikura
Remove group GMD
3f9f1c4 
Change-Id: Ie1594611482ec51e409a28c51c43e88457aa44bb
@thagikura
Fix yaml syntax
10d77c0 
Change-Id: I253ada072534d96e7e56d7e6d054d762781dddd9
@thagikura
Fix yaml syntax
866bd64 
Change-Id: Ia27cc69ceeea0681452f4e30a927fd39416c4b26
@thagikura
Fix reports path
14193a6 
Change-Id: Iae88930e2e04131b50da1ff867bbe44e428c464a
@thagikura
Fix test reports path
cee047c 
Change-Id: I33ee689d01717fec1761415b39d1a373f4a1a8e1
@thagikura
Fix reports path
fcf352f 
Change-Id: I1e6d618c2e1e347cc9ff0e483264f267bd95981e
@thagikura
Insert debug SSH session
3cb9c9d 
Change-Id: Ie57be3a6206bb6959b8d2318a49b33eed6f0f79c
@thagikura
Fix reports path
59f4c83 
Change-Id: Ie082ff1f899b70452e494d65bde07d65fff661e7
@thagikura
Copy link
Contributor Author

Agreed. Let's see the flakiness to compare with ReactiveCircus.

Added GMD to modules that have instrumented tests. Can you have a look again?

@thagikura thagikura requested a review from alexvanyo December 22, 2022 10:54
alexvanyo
alexvanyo approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@alexvanyo alexvanyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo! 🎉

Screen Shot 2023-01-04 at 2 29 53 PM

Looks good to me, just two nits in the workflow and it's unfortunate we can't make a convention plugin at the moment. Ideally we could apply that plugin everywhere, so we can't make a mistake of leaving out any new tests by not adding the managed devices configuration.

.github/workflows/AndroidCIWithGmd.yaml Outdated Show resolved Hide resolved
.github/workflows/AndroidCIWithGmd.yaml Outdated Show resolved Hide resolved
core/database/build.gradle.kts Show resolved Hide resolved
@thagikura
Add TODO to convert GMD definition as a convention plugin
dd89cbf 
Remove setup android SDK for experiment

Change-Id: I55fc1826ffeb9254ca53e7227555ec4879f38079
@thagikura thagikura mentioned this pull request Jan 5, 2023
Closed
2 tasks
@thagikura
Copy link
Contributor Author

Thanks Alex. Addressed your feedback.
Filed #523 as a reminder to convert GMD definitions as a convention plugin.
@dturner is it possible to have a look again and resolve the change request if it looks good?

Thanks!

alexvanyo
alexvanyo reviewed Jan 5, 2023
View reviewed changes
app/build.gradle.kts Outdated Show resolved Hide resolved
@thagikura
Change the link to the GMD bug to the link to the GitHub issue
5dc860e 
Change-Id: I0866369e3d0bbe148ca5ec1f92bad59239a347b8
@thagikura
Copy link
Contributor Author

Friendly reminder to @dturner please resolve the change request if the PR looks good. Thanks!

dturner
dturner approved these changes Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@dturner dturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for doing this.

@thagikura thagikura merged commit 4633609 into main Jan 10, 2023
@dturner dturner deleted the introduce_gmd branch February 21, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexvanyo alexvanyo alexvanyo approved these changes

@dturner dturner dturner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thagikura @dturner @alexvanyo